Skip to content

chore: remove v5.4 from PR template#22795

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
qiancai:remove-5.4-from-pr-template
Apr 27, 2026
Merged

chore: remove v5.4 from PR template#22795
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
qiancai:remove-5.4-from-pr-template

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented Apr 23, 2026

What is changed, added or deleted? (Required)

  • remove the v5.4 checkbox from .github/pull_request_template.md
  • update README.md to mark release-5.4 documentation as archived and no longer updated

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2026
@qiancai qiancai self-assigned this Apr 23, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request archives the TiDB 5.4 documentation by removing the v5.4 option from the pull request template and updating the README to indicate that the 5.4 stable version documentation is now archived and no longer updated. I have no feedback to provide.

@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Apr 23, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 27, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 27, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-27 05:50:43.978847828 +0000 UTC m=+2577049.184207885: ☑️ agreed by Oreoxmt.

@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Apr 27, 2026

/approve

@qiancai qiancai added the lgtm label Apr 27, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 27, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 14bb937 into pingcap:master Apr 27, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants