Skip to content

Updated Header Extension Profile constants#310

Merged
sirzooro merged 1 commit into
pion:masterfrom
sirzooro:hdr_ext_cryptex
Jun 6, 2025
Merged

Updated Header Extension Profile constants#310
sirzooro merged 1 commit into
pion:masterfrom
sirzooro:hdr_ext_cryptex

Conversation

@sirzooro
Copy link
Copy Markdown
Contributor

@sirzooro sirzooro commented Jun 6, 2025

Make Header Extension Profile constants public and added Cryptex ones.

Cryptex (RFC 9335) implementation in pion/srtp will need these constants.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.87%. Comparing base (6469fef) to head (1d257f8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
header_extension.go 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   86.87%   86.87%           
=======================================
  Files          26       26           
  Lines        3108     3108           
=======================================
  Hits         2700     2700           
  Misses        350      350           
  Partials       58       58           
Flag Coverage Δ
go 86.87% <76.92%> (ø)
wasm 86.32% <76.92%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Make Header Extension Profile constants public and added Cryptex ones.
@sirzooro sirzooro requested review from JoTurk, Sean-Der and at-wat June 6, 2025 04:42
Copy link
Copy Markdown
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sirzooro sirzooro merged commit be6ccef into pion:master Jun 6, 2025
14 checks passed
@sirzooro sirzooro deleted the hdr_ext_cryptex branch June 6, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants