fix: FindReferencingConfigMaps and FindReferencingSecrets to scan Cro…#6762
Open
Ram04102007 wants to merge 2 commits into
Open
fix: FindReferencingConfigMaps and FindReferencingSecrets to scan Cro…#6762Ram04102007 wants to merge 2 commits into
Ram04102007 wants to merge 2 commits into
Conversation
…nJob jobTemplate Signed-off-by: Sriram Thiruveedhula <sriram.thiruveedhula2007@gmail.com>
Ram04102007
force-pushed
the
fix/referencing-configmaps-secrets-cronjob
branch
from
52638b5 to
0d88c4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes #6761
While looking at the code after #6528 was fixed, I noticed that
FindReferencingConfigMaps and FindReferencingSecrets have the same
gap — they don't handle CronJobs.
Both functions only walked spec.template.spec.* paths, which works for
Deployments, StatefulSets, and DaemonSets. CronJob wraps its pod template
under spec.jobTemplate.spec.template.spec.*, so all ConfigMap/Secret
references inside a CronJob were silently missed.
Added the missing nestedStringSlice probes for all jobTemplate paths
in both functions, across both kubernetes and kubernetes_multicluster
provider packages. 10 new test cases added, all passing.
Does this PR introduce a user-facing change?
Yes — PipeCD now correctly detects ConfigMap/Secret references in CronJobs,
enabling proper drift detection and re-deploy triggering for CronJob workloads.