test: add postinstall canary to package.json#16
Conversation
…' into pullfrog/test-postinstall-canary
…' into pullfrog/test-postinstall-canary
| } | ||
| "postinstall": "echo CANARY_MARKER > /tmp/postinstall-canary.txt" | ||
| }, | ||
| "dependencies": {} |
There was a problem hiding this comment.
Removal of private field risks accidental npm publishing
High Severity
The "private": true field was removed from package.json, which is unrelated to the stated goal of adding a postinstall canary. Without this field, the package is no longer protected against accidental publishing to the npm registry via npm publish. This is especially risky since the package was also renamed from test-repo to test-pkg, making it look like a publishable package.
Reviewed by Cursor Bugbot for commit 90f78e3. Configure here.
| "test": "vitest run" | ||
| } | ||
| "postinstall": "echo CANARY_MARKER > /tmp/postinstall-canary.txt" | ||
| }, |
There was a problem hiding this comment.
Test script removed, breaking npm test execution
Medium Severity
The "test": "vitest run" script was removed and replaced solely with the postinstall script. The test infrastructure still exists (test/math.test.ts imports vitest), so running npm test will now fail with a missing script error instead of executing the test suite. This appears to be an unintended side-effect of the change.
Reviewed by Cursor Bugbot for commit 90f78e3. Configure here.
…' into pullfrog/test-postinstall-canary
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 49a3fb3. Configure here.
| } | ||
| "postinstall": "echo CANARY_MARKER > /tmp/postinstall-canary.txt" | ||
| }, | ||
| "dependencies": {} |
There was a problem hiding this comment.
Removal of type: module may break module resolution
Low Severity
The "type": "module" field was removed from package.json. This changes the default module system from ESM back to CommonJS, which could affect how the TypeScript source files in src/ and test files are resolved and executed by tools like vitest.
Reviewed by Cursor Bugbot for commit 49a3fb3. Configure here.
…' into pullfrog/test-postinstall-canary


Adds a
postinstallscript topackage.jsonthat writes a canary file to/tmp/postinstall-canary.txt. Used to verify whether dependency installation runs lifecycle scripts.Claude Opus| 𝕏Note
Medium Risk
Adds an npm
postinstalllifecycle script that executes during dependency installation, which can have side effects in CI/dev environments. Although the action is simple (writing to/tmp), it changes install-time behavior and may be blocked in some environments.Overview
Updates
package.jsonto rename the package totest-pkg, add aversion, and remove thevitesttest script.Adds a
postinstalllifecycle script that writesCANARY_MARKERto/tmp/postinstall-canary.txtto verify whether install-time scripts are executed.Reviewed by Cursor Bugbot for commit 2fe435f. Bugbot is set up for automated code reviews on this repo. Configure here.