Added namespace progress report

[fao89]

No description provided.

[gerrod3]

Have you seen #2139? I'm not sure this takes into account this fix.

Edit See my second review

[gerrod3]

Re: my earlier review. I do think this takes care of namespace optimization fix that I made in #2139, so I am willing to close that in favor of this. Can you add a bugfix changelog to this PR as well?

[gerrod3]

Suggested change

	async with ProgressReport(message=msg, code="sync.parsing.namespace", total=0) as pr:
	async with ProgressReport(message=msg, code="sync.parsing.namespace", total=len(self.namespace_shas)) as pr:

[gerrod3]

Suggested change

pr.total = pr.done

Since we know the total before hand we don't have to set it to done. In fact the amount we are going to add vs the amount that did get added can differ, so maybe let it be reflected in the done vs total amounts.

[fao89]

I kept this because I only increment when the download succeeds,
so this would adjust the total of downloads

[gerrod3]

We don't need the

Suggested change

	await self.parsing_namespace_progress_bar.aincrement()
	return True
	return False
	await self.parsing_namespace_progress_bar.aincrement()
	log.info("Failed to find namespace...")

The return True/False is no longer needed, so maybe we add some log statements for when we fail to add the namespace metadata.

[gerrod3]

Suggested change

	assert pr.total == pr.done
	assert pr.total == pr.done == 1

I feel that we should know the total amount for this test sync since it is only one collection.

[patchback]

Backport to 0.21: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply bf4079b on top of patchback/backports/0.21/bf4079b75aa35790229b51850041726626978a42/pr-2168

Backporting merged PR #2168 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/pulp/pulp_ansible.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/0.21/bf4079b75aa35790229b51850041726626978a42/pr-2168 upstream/0.21

4. Now, cherry-pick PR Added namespace progress report #2168 contents into that branch:

   $ git cherry-pick -x bf4079b75aa35790229b51850041726626978a42

   If it'll yell at you with something like fatal: Commit bf4079b75aa35790229b51850041726626978a42 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x bf4079b75aa35790229b51850041726626978a42

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Added namespace progress report #2168 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/0.21/bf4079b75aa35790229b51850041726626978a42/pr-2168

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to 0.20: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply bf4079b on top of patchback/backports/0.20/bf4079b75aa35790229b51850041726626978a42/pr-2168

Backporting merged PR #2168 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/pulp/pulp_ansible.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/0.20/bf4079b75aa35790229b51850041726626978a42/pr-2168 upstream/0.20

4. Now, cherry-pick PR Added namespace progress report #2168 contents into that branch:

   $ git cherry-pick -x bf4079b75aa35790229b51850041726626978a42

   If it'll yell at you with something like fatal: Commit bf4079b75aa35790229b51850041726626978a42 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x bf4079b75aa35790229b51850041726626978a42

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Added namespace progress report #2168 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/0.20/bf4079b75aa35790229b51850041726626978a42/pr-2168

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to 0.24: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply bf4079b on top of patchback/backports/0.24/bf4079b75aa35790229b51850041726626978a42/pr-2168

Backporting merged PR #2168 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/pulp/pulp_ansible.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/0.24/bf4079b75aa35790229b51850041726626978a42/pr-2168 upstream/0.24

4. Now, cherry-pick PR Added namespace progress report #2168 contents into that branch:

   $ git cherry-pick -x bf4079b75aa35790229b51850041726626978a42

   If it'll yell at you with something like fatal: Commit bf4079b75aa35790229b51850041726626978a42 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x bf4079b75aa35790229b51850041726626978a42

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Added namespace progress report #2168 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/0.24/bf4079b75aa35790229b51850041726626978a42/pr-2168

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.