Add CodSpeed performance benchmarking integration#54
Closed
codspeed-hq[bot] wants to merge 1 commit intomainfrom
Closed
Add CodSpeed performance benchmarking integration#54codspeed-hq[bot] wants to merge 1 commit intomainfrom
codspeed-hq[bot] wants to merge 1 commit intomainfrom
Conversation
Member
|
Superseded by new PR from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates CodSpeed for continuous performance benchmarking of DataFusion.
Changes
Workspace dependency update: Replaced
criterion = "0.8"withcodspeed-criterion-compat = "4.3.0"using Cargo dependency renaming (package = "codspeed-criterion-compat"). This is a drop-in replacement that preserves all existinguse criterion::*;imports across the codebase -- no benchmark source code changes required.CI workflow: Added
.github/workflows/codspeed.ymlthat builds and runs all criterion benchmarks with CodSpeed's CPU simulation instrument on every push tomainand on pull requests. Uses OIDC authentication (no secrets required).README badge: Added CodSpeed badge linking to the project dashboard.
How it works
The
codspeed-criterion-compatcrate acts as a passthrough when runningcargo benchnormally, so existing benchmark workflows are unaffected. When benchmarks are run throughcargo codspeedin CI, CodSpeed instruments the execution to produce consistent, hardware-agnostic measurements.Affected crates
All 13 crates with criterion benchmarks are covered automatically via the workspace dependency:
datafusion(core)datafusion-commondatafusion-datasourcedatafusion-datasource-parquetdatafusion-functionsdatafusion-functions-aggregatedatafusion-functions-aggregate-commondatafusion-functions-nesteddatafusion-functions-windowdatafusion-optimizerdatafusion-physical-exprdatafusion-physical-plandatafusion-sparkNext steps