Skip to content

reup spec000 & some linting [2026-04-15]#204

Merged
jGaboardi merged 3 commits into
pysal:mainfrom
jGaboardi:reup-spec000-2026-04-16
Apr 27, 2026
Merged

reup spec000 & some linting [2026-04-15]#204
jGaboardi merged 3 commits into
pysal:mainfrom
jGaboardi:reup-spec000-2026-04-16

Conversation

@jGaboardi
Copy link
Copy Markdown
Member

@jGaboardi jGaboardi commented Apr 16, 2026

This PR:

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.1%. Comparing base (a798e9e) to head (53fe314).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pointpats/geometry.py 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #204     +/-   ##
=======================================
+ Coverage   72.9%   73.1%   +0.3%     
=======================================
  Files         12      12             
  Lines       2118    2111      -7     
=======================================
+ Hits        1543    1544      +1     
+ Misses       575     567      -8     
Files with missing lines Coverage Δ
pointpats/__init__.py 100.0% <100.0%> (ø)
pointpats/centrography.py 84.0% <100.0%> (ø)
pointpats/geometry.py 57.3% <0.0%> (+2.7%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi
Copy link
Copy Markdown
Member Author

jGaboardi commented Apr 16, 2026

@jGaboardi jGaboardi marked this pull request as ready for review April 16, 2026 02:11
Comment thread .github/workflows/tests.yaml Outdated
os: macos-latest # Apple Silicon
- environment-file: ci/envs/314-numba-latest.yaml
os: windows-latest
# # with numba -- leave off for now; numba-izde code seems broken
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should surface that by accepting red CI.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll add back in the numba stuff to this PR

@jGaboardi jGaboardi requested a review from martinfleis April 25, 2026 20:40
@jGaboardi jGaboardi merged commit 527491b into pysal:main Apr 27, 2026
10 of 14 checks passed
@jGaboardi jGaboardi deleted the reup-spec000-2026-04-16 branch April 27, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants