Skip to content

Add CI job for pytest development version#1429

Open
evjames4 wants to merge 1 commit intopytest-dev:mainfrom
evjames4:hw6b-pytest-dev-ci
Open

Add CI job for pytest development version#1429
evjames4 wants to merge 1 commit intopytest-dev:mainfrom
evjames4:hw6b-pytest-dev-ci

Conversation

@evjames4
Copy link
Copy Markdown

Closes #1132

This adds a separate CI job to test pytest-asyncio against the development version of pytest while keeping the existing stable test matrix unchanged.

Summary:

  • adds a new GitHub Actions job for pytest dev testing
  • uses a reduced Ubuntu/Python 3.13 setup
  • runs tests via tox to match existing workflow
  • includes coverage artifact handling
  • updates the check job dependencies accordingly

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.53%. Comparing base (b6f574c) to head (ba4e4c5).
⚠️ Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1429      +/-   ##
==========================================
- Coverage   95.13%   94.53%   -0.61%     
==========================================
  Files           2        2              
  Lines         473      512      +39     
  Branches       57       61       +4     
==========================================
+ Hits          450      484      +34     
- Misses         17       22       +5     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@seifertm seifertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @evjames4 !

It's desirable to have parity between the CI/CD workflow and the local development environment. That means, it should be possible to run the tests against pytest dev in the local development environment.

There was another Pull Request which seems like it had this figured out. Can you take a look and extend the local development environment so that there's a tox environment that runs all tests against the development version of pytest?

name: Check
if: always()
needs: [build, lint, test]
needs: [build, lint, test, test-pytest-dev]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to make this a mandatory CI job. It's completely fine to merge code, even though test-pytest-dev does not run successfully.

We want to have the CI job to make incompatibilities visible only, not to block on them.

Suggested change
needs: [build, lint, test, test-pytest-dev]
needs: [build, lint, test]

persist-credentials: false
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405
with:
python-version: '3.13'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just use the PYTHON_LATEST, in order to keep Python updates in the workflow simple.

Suggested change
python-version: '3.13'
python-version: ${{ env.PYTHON_LATEST }}

if-no-files-found: error

test-pytest-dev:
name: ubuntu - Python 3.13 - pytest dev
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: ubuntu - Python 3.13 - pytest dev
name: ubuntu - Python ${{ env.PYTHON_LATEST }} - pytest dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: add job that that uses pytest-dev version

3 participants