[xpu][mx] Enable mx matmul tests on xpu#4251
Open
ugolowic wants to merge 1 commit intopytorch:mainfrom
Open
Conversation
ugolowic
requested review from
danielvegamyhre,
drisspg,
jerryzh168 and
vkuzo
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4251
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
- Parametrize the mx matmul tests by device. - Use F.scaled_mm (torch 2.10+) which takes explicit ScalingType/SwizzleType args enabling non-CUDA backends, fall back to torch._scaled_mm on older versions (CUDA-only, implicit layout). Signed-off-by: Ula Golowicz <urszula.golowicz@intel.com>
ugolowic
force-pushed
the
enable_mx_mm_tests
branch
from
865a1a2 to
9efa4a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the context of #3576.
To enable matmul tests on xpu, the "new" PyTorch matmul API needs to be used with torch 2.10+.
The older
torch._scaled_mminfers scaling type and memory layout from tensor shapes alone. This only works on CUDA with the specific swizzled scale layout the hardware expects.PyTorch 2.10 introduced
torch.functional.scaled_mmas the public API. It takes explicitScalingTypeandSwizzleTypearguments, making it possible to specify non-swizzled layouts needed by backends like XPU.