[Pallas] Update xfail reasons for examples to reflect current errors#2074
Draft
[Pallas] Update xfail reasons for examples to reflect current errors#2074
Conversation
The stored xfail reasons on many examples were stale — most dated back to when the Pallas backend first xfailed them, but the underlying error has since moved (or was always something different). Ran the full xfailed list against current origin/main and updated each reason to match the actual error observed today. The updates also surface some new clusters worth tracking: - "int tensor indexing not yet lowered for TPU" (5 tests: embedding_pointers/block_ptr, concat, cross_entropy, gather_gemv) — all hit lowering.py:1699 - "Pallas rejects int64 inputs (jagged offsets)" (6 tests: all jagged kernels) — blocked in _pallas_check_dtypes - "broadcasting shape mismatch in codegen" (5 tests: matmul_layernorm_dynamic_shapes, concat_block_ptr, se_bwd_dx/da, grpo_loss_bwd) — TypeError from jax.numpy broadcast - "Mosaic compile error" (2 tests: attention_dynamic, layernorm_bwd) No behavior change; xfail markers still apply, only the `reason=` string is updated.
a4ff6ff to
efe0fba
Compare
jansel
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.