Small attention optimization: pre-scale q tile with qk_scale#2157
Merged
AmesingFlank merged 2 commits intomainfrom May 1, 2026
Merged
Small attention optimization: pre-scale q tile with qk_scale#2157AmesingFlank merged 2 commits intomainfrom
AmesingFlank merged 2 commits intomainfrom
Conversation
b3a887c to
d4de5d5
Compare
0a7a1a9 to
5625c40
Compare
norx1991
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
m_iupdate in example attention kernel #2156Small optimization, discovered by @cota. Here,
qis of size(block_q, head_dim)which is smaller thanqk, which is(block_q, block_k). Typically,head_dimis 64/128 which is likely smaller thanblock_k. So this results in slightly less ALU pressure.On TPUs, with
This optimization provides a 1~2 TFLOPs increasing, from a base line of 290 TFLOPs.
It's not much, but it's something.