Flatpak prototype#676
Merged
Merged
Conversation
* Only build CI on changes in the Quelea/ (Java app) directory * Use other GH Actions to simplify the script and remove static linking to JDK downloads * Use a Windows Github Actions Runner to compile and package the Windows standalone * Change the release GH Action to a more actively maintained one, and use newlines to make it more readible.
…version expressions
Contributor
Author
|
Changed this PR to a draft since I'll work on the CI-build making a .flatpak bundle file so users will be able to install it without using the Flathub repository. |
Contributor
Author
|
It now creates a .flatpak file (Flatpak Bundle) and adds it to the Releases. |
Contributor
Author
|
It does increase the build action time to 11 mins. It might be nicer to split it up or also add an if like with the publish release step |
Closed
berry120
approved these changes
May 3, 2025
Member
berry120
left a comment
berry120
left a comment
There was a problem hiding this comment.
Let's give this a go - let me know if there's any issues with it after merge!
Contributor
Author
|
After uninstalling every flatpak and using the .flatpak bundle file from this repo's releases page/CI-RELEASE it installed succesfully! :) Opens up good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Flatpak build scripts needs an archive/tarball of the Quelea application (
dist/) with the Quelea.jar in it, so I had to tweak a couple of things with the build.To build the Flatpak you need to have Flatpak installed,
and run the following commands:1. Go to releases and download .flatpak bundle file
You can now go to the releases and download the .flatpak bundle file. With this bundle file you can easily install it by using either
flatpak install quelea-CI-UNSTABLE.flatpakor double clicking it and opening it with your Flatpak frontend manager GUI of choice (Gnome Software or KDE Discover for example), and installing it through the manager.Notes
JavaFX <= 23 has an issue where maximized windows will shrink to half the screen's size when opening dialogs on Linux (/Wayland). This is fixed in JavaFX 24, so I used a JRE w/ FX 24 from Azul for the Flatpak, which fixes the issue and seems to run fine. Might need more testing though.
I also tested this against version 21 from Azul but the bugfix hasn't been backported.
This PR only uses JDK/JFX 24 for the Flatpak.
Does it work?
The applications open, but I haven't tested running a full service/schedule in it or in the production setting.
Follow-up
After the merge, some links in the manifest (flatpak/org.quelea.Quelea.yml) will need to be changed to reference this repository instead of my fork.