GH Action: PR build/check#678
Merged
Merged
Conversation
Contributor
Author
|
Oh it apparently also already executes on the PR before even having been merged. Didn't expect that :P |
Contributor
Author
|
|
berry120
reviewed
Apr 24, 2025
Member
berry120
left a comment
berry120
left a comment
There was a problem hiding this comment.
This is a great idea, thanks!
Only thing we'll have to watch is that this doesn't consume too many action minutes, but hopefully shouldn't be a problem unless we're inundated with PRs.
berry120
approved these changes
Apr 24, 2025
Contributor
Author
|
Awesome, thanks for the fast review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses PR #677 as base
This PR adds a trigger to the build.yml Github Action to also execute the Build Action on PRs opened to Quelea. It will however skip the publish release step (it won't publish PRs as a release), but it will upload the standalones created by the build as an artifact, which can be found by going to the "Build CI release / release (pull_request) -> View Details -> Summary -> scroll down to the "Artifacts" section.
The artifact contains the standalone installers, so that you can test the standalone installers produced by the PR without having to build it manually yourself. It also serves as a check so that you know the PR works and builds without issues. If the build fails, it'll immediately let the PR submitter know so they can fix it.