Change GH Action JDK+FX Zulu to just the Temurin JDK#681
Merged
Conversation
The Temurin JDK comes preinstalled on the Github-hosted Runners so it saves some time from installing. The FX libraries aren't used for building, but are rather only needed for the runtime, which is taken care of by bundling the standalone installers with the JRE+FX (Zulu) from Azul. (Not needed for build as the JFX libraries are provided by the JavaFX plugin and the dependencies from build.gradle
berry120
approved these changes
Apr 26, 2025
Member
berry120
left a comment
berry120
left a comment
There was a problem hiding this comment.
Awesome, yup might as well use this one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Temurin JDK comes preinstalled on the Github-hosted Runners so it saves some time from installing. The FX libraries aren't used for building, but are rather only needed for the runtime, which is still taken care of because the runtimes are installed by the the standalone installers that still come with the bundled JRE+FX (Zulu) from Azul.
(The libraries required during compilation/building with Gradle are provided by the Gradle, by the JavaFX plugin and the dependencies from build.gradle and don't need to come bundled with the JDK; only for buildtime/compile, only runtime needs and still gets that JDK+FX bundle)