Parameterized write/print/display for numbers#3222
Open
elfprince13 wants to merge 3 commits intoracket:masterfrom
Open
Parameterized write/print/display for numbers#3222elfprince13 wants to merge 3 commits intoracket:masterfrom
elfprince13 wants to merge 3 commits intoracket:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request provides user control over how numbers are printed by introducing a new parameter,
print-number->string-proc.One use-case is to allow development of localized languages wherein a reader extension for different number representations can be paired with parameterized writing to output numbers using the same syntax.
This approach should:
a) have better performance than boxing your numbers in a structure type with writer extensions
b) be more easily composable than writing new write/print/display handlers from scratch and installing them on every port that might be used.