Enable KEM certificate issuance via CLI#5529
Open
falko-strenzke wants to merge 5 commits intorandombit:masterfrom
Open
Enable KEM certificate issuance via CLI#5529falko-strenzke wants to merge 5 commits intorandombit:masterfrom
falko-strenzke wants to merge 5 commits intorandombit:masterfrom
Conversation
randombit
reviewed
Apr 15, 2026
| } | ||
|
|
||
| // TODO(Botan4) remove --emsa option and this logic | ||
| const std::string padding = [&]() { |
Owner
There was a problem hiding this comment.
Seems unnecessary to have any compatibility considerations here
randombit
reviewed
Apr 15, 2026
|
|
||
| auto key = load_private_key(ca_key_file, passphrase); | ||
|
|
||
| Botan::X509_Cert_Options opts; |
Owner
There was a problem hiding this comment.
This shouldn't be used here, just write the subject DN directly
randombit
requested changes
Apr 15, 2026
Owner
randombit
left a comment
randombit
left a comment
There was a problem hiding this comment.
Basic idea is fine, could be a lot simpler in implementation see prev comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4516.