Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate the wrong API and provide a new one, based on how the JSON.GET works.
Closes #3711
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Note
Medium Risk
Introduces new
jsonGetValue*methods and deprecates existingjsonGet*list-returning APIs, which can impact downstream consumers (especially coroutines) despite being source-compatible for Java via deprecation only.Overview
Aligns the
JSON.GETAPI with Redis behavior by adding single-result methods:jsonGetValue(...)returningJsonValueandjsonGetValueRaw(...)returning a rawString, implemented across async/reactive/sync, cluster node selection, and coroutines.Marks the existing
jsonGet(...)/jsonGetRaw(...)list-returning methods as deprecated (since they imply multiple bulk replies), adds a newJsonValueOutputfor parsing a single reply, and expands integration tests to cover multi-key/multi-path behavior and the new single-value APIs.Written by Cursor Bugbot for commit c07e1b4. This will update automatically on new commits. Configure here.