Skip to content

internal/vcs: remove SYSTEMROOT workaround for Windows#299

Merged
mvdan merged 1 commit intorogpeppe:masterfrom
mvdan:systemroot
Apr 15, 2026
Merged

internal/vcs: remove SYSTEMROOT workaround for Windows#299
mvdan merged 1 commit intorogpeppe:masterfrom
mvdan:systemroot

Conversation

@mvdan
Copy link
Copy Markdown
Collaborator

@mvdan mvdan commented Aug 18, 2025

(see commit message)

https://go.dev/issue/25513 was resolved in Go 1.13
such that %SYSTEMROOT% is always inherited by sub-processes by default.
@mvdan mvdan requested review from myitcv and rogpeppe August 18, 2025 11:07
Copy link
Copy Markdown
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvdan mvdan merged commit 3030644 into rogpeppe:master Apr 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants