Wire up _client reference for Job.status() to poll disconnect jobs#19
Open
Arittra-Bag wants to merge 1 commit into
Open
Wire up _client reference for Job.status() to poll disconnect jobs#19Arittra-Bag wants to merge 1 commit into
Arittra-Bag wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes polling for asynchronous SSH “disconnect all users” jobs by ensuring Job instances created by SSHClient have a valid AtomicClient reference, allowing Job.status() to call into sites.get_job_status() as intended.
Changes:
- Update
AtomicClient.__init__to attach the main client reference tossh(self.ssh._client = self), matching the existingsiteswiring. - Generalize the inline comment to reflect that multiple resource clients may return
Jobobjects requiring a client reference.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Job.status()failure for SSH disconnect jobsSSHClient.disconnect_all_users()returns aJoband assignsjob._client = self._clientso the job can later fetch status. However,AtomicClient.__init__only initialized the client reference forsites, leavingssh._clientunset.As a result, SSH disconnect jobs were created with a
Noneclient reference, causingJob.status()to raise:RuntimeError: Job object must be initialized with a client reference to fetch status.This change wires
self.ssh._client = selfduringAtomicClientinitialization, matching the existingsitessetup and allowing SSH disconnect jobs to fetch their status correctly.