feat: Website and docusaurus telemetry: cookie consent#289
Open
ngvtuan wants to merge 2 commits intoshuttle-hq:masterfrom
Open
feat: Website and docusaurus telemetry: cookie consent#289ngvtuan wants to merge 2 commits intoshuttle-hq:masterfrom
ngvtuan wants to merge 2 commits intoshuttle-hq:masterfrom
Conversation
ngvtuan
changed the title
christos-h
suggested changes
Jan 31, 2022
Member
christos-h
left a comment
christos-h
left a comment
There was a problem hiding this comment.
This looks great! Also tested it locally and everything works with flying colors. Like the other PR - could we split it into functional changes and formatting changes in separate PRs please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.