Open
Conversation
mxsrc
force-pushed
the
tls-cert-use
branch
5 times, most recently
from
3566fef to
b65b730
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a setting to provide TLS certificate and key. When these are present, API, SNodeAPI, and SPDK Proxy run TLS-based servers. Otherwise, regular HTTP servers are used, so this is a non-breaking change.
Tested by confirming that all three adapted services respond to HTTP requests when TLS configuration is absent, and to HTTPS when it is present.
The
IP_PATTERNchange is unrelated. I noticed it when testing and decided to simply include the fix here.