feat(helm): expose exporter.staleness_threshold#77
Merged
softberries merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
Support the new staleness_threshold config field (merged in #76) from the helm chart. Rendered conditionally so operators who omit it fall back to the code's poll_interval*3 default.
Contributor
There was a problem hiding this comment.
Pull request overview
Exposes the existing exporter.staleness_threshold application setting through the Helm chart so operators can optionally configure it via values.
Changes:
- Adds conditional rendering of
staleness_thresholdunder the[exporter]TOML section when the value is set. - Documents the setting in
values.yamlwith rationale and an example.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
helm/klag-exporter/templates/configmap.yaml |
Conditionally emits staleness_threshold = "…" under [exporter] based on Values.config.exporter.staleness_threshold. |
helm/klag-exporter/values.yaml |
Adds inline documentation and a commented example for config.exporter.staleness_threshold. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exporter.staleness_thresholdinconfigmap.yaml.values.yamlunderconfig.exporter.Follow-up to #76 (already merged), which added the
staleness_thresholdconfig field to the code but didn't surface it in the helm chart.Behavior
config.exporter.staleness_thresholdget no new rendering — the code's default (poll_interval × 3) kicks in, matching the old hard-coded 90s at the default 30s poll interval.Changes
helm/klag-exporter/templates/configmap.yaml—{{- if .staleness_threshold }}block under[exporter].helm/klag-exporter/values.yaml— commented# staleness_threshold: "3m"with a short rationale.Test plan
helm templateagainst a values file that omitsstaleness_threshold→ line is not rendered in the output ConfigMap.helm templatewithstaleness_threshold: "5m"set →staleness_threshold = "5m"appears under[exporter].