fix: replace broken NATS health check with port wait step#8
Merged
peter-svensson merged 2 commits intomainfrom Mar 8, 2026
Merged
fix: replace broken NATS health check with port wait step#8peter-svensson merged 2 commits intomainfrom
peter-svensson merged 2 commits intomainfrom
Conversation
The NATS Docker image is scratch-based with no shell or `true` binary, so the health-cmd always fails. Replace with a host-side nc port check.
- Add @types/node to devDependencies (fixes node:crypto TS2307) - Vendor topology.json into testdata/ (removes monorepo path dependency) - Fix topology test path from ../../../../specification/... to ../testdata/ - Skip queue-publish topology test (not yet implemented for NATS)
This was referenced Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
truebinary), so the--health-cmd "true"always failsnc -zport check step that waits for NATS to be readyTest plan