add copying to list of license file names#74
Open
axon-consultancy wants to merge 1 commit intosrc-d:masterfrom
Open
add copying to list of license file names#74axon-consultancy wants to merge 1 commit intosrc-d:masterfrom
axon-consultancy wants to merge 1 commit intosrc-d:masterfrom
Conversation
vmarkovtsev
approved these changes
May 1, 2020
Collaborator
|
Thanks a lot for this contribution! I am back from coronavirus disaster, sorry for making you wait. Can you please sign the DCO: https://github.com/src-d/go-license-detector/pull/74/checks?check_run_id=588276834 |
|
A few lines above in the same list, there is already |
Contributor
|
@axon-consultancy will be great if you can submit your PR to https://github.com/go-enry/go-license-detector, we moved the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some project use a
COPYINGfile for their license. This PR adds this file to the license list that is used to find files to scan. As a reference, my project has 72 dependencies for which the detector was able to detect 64. With the copying file it detected licenses in all repo's, so it looks like it's quite common.The
COPYINGfile seems to be a convention used in the GNU project (http://www.gnu.org/licenses/gpl-howto.html).example: https://github.com/aristanetworks/goarista