This repository was archived by the owner on May 17, 2020. It is now read-only.
Existence check for title in oembedData object.#86
Open
nathanielford wants to merge 1 commit intostarfishmod:masterfrom
Open
Existence check for title in oembedData object.#86nathanielford wants to merge 1 commit intostarfishmod:masterfrom
nathanielford wants to merge 1 commit intostarfishmod:masterfrom
Conversation
Checks to make sure that oembedData.title even exists within the object; failure to exist results in 'undefined' to be inserted in the link. At least one third party (Flickr) fails to return this object with a title attribute. Example: http://www.flickr.com/photos/ahattar/8158065331/lightbox/ Goes to a login page, but an attempt to embed will return a 'success' result without a title object.
|
The NFL would like to continue support for this plugin. Please re-submit your pull request with https://github.com/nfl/jquery-oembed-all. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks to make sure that oembedData.title even exists within the object; failure to exist results in 'undefined' to be inserted in the link. At least one third party (Flickr) fails to return this object with a title attribute.
Example:
http://www.flickr.com/photos/ahattar/8158065331/lightbox/
Goes to a login page, but an attempt to embed will return a 'success' result without a title object.