Add WAL journal mode support#1359
Merged
Merged
Conversation
Summary: - Add journal mode, synchronous, WAL checkpoint, and WAL auto-checkpoint pragmas. - Add opt-in WAL setup via Connection initializers and enableWAL(). - Document WAL usage and migration notes. - Cover WAL behavior, read-only URI handling, and temporary sidecar cleanup in tests.
Contributor
Author
|
@jberkel We always encounter this warning in the figure, so I plan to adapt the WAL mode to SQLite.swift. Can you check if it is suitable for merging into the main branch? |
Collaborator
|
looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Thanks for taking the time to submit a pull request.
Before submitting, please do the following:
make lintto check if there are any format errors (install swiftlint first)swift testto see if the tests pass.