Skip to content

Issue project 863#4018

Merged
mulkieran merged 2 commits into
stratis-storage:masterfrom
mulkieran:issue_project_863
May 6, 2026
Merged

Issue project 863#4018
mulkieran merged 2 commits into
stratis-storage:masterfrom
mulkieran:issue_project_863

Conversation

@mulkieran
Copy link
Copy Markdown
Member

@mulkieran mulkieran commented May 6, 2026

Related stratis-storage/project#863

Summary by CodeRabbit

Chores

  • Updated GitHub Actions workflow configuration with improved YAML linting rules to ensure consistent formatting standards across all continuous integration workflows.
  • Consolidated linting directives into centralized configuration for better maintainability and consistency management.

mulkieran added 2 commits May 6, 2026 18:32
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran added this to the v3.9.1 milestone May 6, 2026
@mulkieran mulkieran self-assigned this May 6, 2026
@mulkieran mulkieran removed this from 2026April May 6, 2026
@mulkieran mulkieran added this to 2026May May 6, 2026
@mulkieran mulkieran moved this to In Review in 2026May May 6, 2026
@mulkieran
Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 26c60872-f442-47fe-be0d-e8f3938347df

📥 Commits

Reviewing files that changed from the base of the PR and between 6941873 and 3b3b7ad.

📒 Files selected for processing (10)
  • .github/workflows/cargo.yml
  • .github/workflows/dummy.yml
  • .github/workflows/fedora.yml
  • .github/workflows/main.yml
  • .github/workflows/nightly.yml
  • .github/workflows/support.yml
  • .github/workflows/ubuntu.yml
  • .github/workflows/valgrind.yml
  • .packit.yaml
  • .yamllint.yaml
💤 Files with no reviewable changes (9)
  • .github/workflows/main.yml
  • .github/workflows/cargo.yml
  • .github/workflows/valgrind.yml
  • .github/workflows/dummy.yml
  • .github/workflows/fedora.yml
  • .github/workflows/nightly.yml
  • .github/workflows/support.yml
  • .packit.yaml
  • .github/workflows/ubuntu.yml

Walkthrough

This PR refactors yamllint directives across the repository. The .yamllint.yaml configuration is updated to globally ignore the truthy rule for workflow files, enabling removal of per-file truthy disable comments from most workflows while adding them to two specific workflows that require special handling.

Changes

Yamllint Configuration and Workflow Directives

Layer / File(s) Summary
yamllint Configuration
.yamllint.yaml
Adds rules.truthy.ignore configuration to exclude .github/workflows/*.yml from truthy rule validation.
Workflow Consolidation
.github/workflows/dummy.yml, .github/workflows/fedora.yml, .github/workflows/main.yml, .github/workflows/nightly.yml, .github/workflows/support.yml, .github/workflows/ubuntu.yml
Removes # yamllint disable-line rule:truthy comments from workflow headers, now handled by global yamllint config.
Workflow Special Cases
.github/workflows/cargo.yml, .github/workflows/valgrind.yml
Adds # yamllint disable-line rule:truthy directives to these specific workflow files.
Packit Configuration
.packit.yaml
Removes # yamllint disable rule:line-length comment from file header.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • jbaublitz
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Issue project 863' is vague and non-descriptive, using only an issue reference without conveying what changes were made or the purpose of the pull request. Use a descriptive title that explains the main change, such as 'Disable yamllint truthy rule for workflow files' or 'Configure yamllint to ignore truthy rule in workflows'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran mulkieran merged commit fc7bc81 into stratis-storage:master May 6, 2026
39 of 48 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in 2026May May 6, 2026
@mulkieran mulkieran deleted the issue_project_863 branch May 6, 2026 22:50
@packit-as-a-service
Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-stratisd-4018-copr_pull
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran moved this from Done to Done(1) in 2026May May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done(1)

Development

Successfully merging this pull request may close these issues.

1 participant