Fix for #252 - Build command fails when using Postgres#253
Open
Fix for #252 - Build command fails when using Postgres#253
Conversation
alexander-schranz
requested changes
Jul 3, 2024
Member
alexander-schranz
left a comment
alexander-schranz
left a comment
There was a problem hiding this comment.
Thx for the merge request please create a entry for UPGRADE to move existing indexes from idx_<column> to idx_<your_entity>_<column>
Comment on lines
+120
to
+125
| CREATE INDEX idx_<your_entity>_dimension ON <your_entity>_content (stage, locale); | ||
| CREATE INDEX idx_<your_entity>_locale ON <your_entity>_content (locale); | ||
| CREATE INDEX idx_<your_entity>_stage ON <your_entity>_content (stage); | ||
| CREATE INDEX idx_<your_entity>_template_key ON <your_entity>_content (templateKey); | ||
| CREATE INDEX idx_<your_entity>_workflow_place ON <your_entity>_content (workflowPlace); | ||
| CREATE INDEX idx_<your_entity>_workflow_published ON <your_entity>_content (workflowPublished); |
Member
There was a problem hiding this comment.
Do not edit the old UPGRADE this need be part of a new upgrade migrating existing idx_dimension to idx_your_entity>_...
alexander-schranz
added
the
Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a quick fix, hope you're okay with what I've done for the index name generation.
Pull should be good for both 0.6 and 0.7 branches.