Open
Conversation
Signed-off-by: r1235613 <r1235613@gmail.com>
creamsoup
reviewed
May 27, 2021
| try: | ||
| requests.post(settings.get('ifttt_webhook_url'), data={'value1': title, 'value2': body}, timeout=10) | ||
| except requests.exceptions.Timeout: | ||
| logging.error(f"Connecting to IFTTT timeout.(Default is 10 sec)") |
There was a problem hiding this comment.
Timeout doesn't necessarily mean Connection timeout as request doc mentions it catches both
requests.exceptions.ConnectTimeout , requests.exceptions.ReadTimeout errors.
creamsoup
reviewed
May 27, 2021
| except requests.exceptions.Timeout: | ||
| logging.error(f"Connecting to IFTTT timeout.(Default is 10 sec)") | ||
| except requests.exceptions.RequestException as e: | ||
| logging.error(f"Fail to connect IFTTT-{str(e)}") |
There was a problem hiding this comment.
this is also misleadning. this can be anything, failed to connect is only 1 case of many.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a timeout setting.
In the current program, if there is a problem with the connection, it can cause the program to hang for a long time.