data_source_device: port wait_for to plugin framework#678
Merged
neinkeinkaffee merged 3 commits intomainfrom Apr 15, 2026
Merged
data_source_device: port wait_for to plugin framework#678neinkeinkaffee merged 3 commits intomainfrom
neinkeinkaffee merged 3 commits intomainfrom
Conversation
neinkeinkaffee
force-pushed
the
gesa/device-datasource-waitfor
branch
4 times, most recently
from
a3d8fd8 to
ed0d2e4
Compare
neinkeinkaffee
force-pushed
the
gesa/device-datasource-waitfor
branch
2 times, most recently
from
c675fc0 to
b65e061
Compare
neinkeinkaffee
changed the title
neinkeinkaffee
force-pushed
the
gesa/device-datasource-waitfor
branch
from
b65e061 to
57a6673
Compare
neinkeinkaffee
commented
Apr 13, 2026
| }, | ||
| }) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This unit test is tied to the unexported retryWithDeadline function and might not be worth keeping as long as we're fine with testing the retry logic in the device data source's unit test.
Member
There was a problem hiding this comment.
I think we could also move retryWithDeadline directly into the device data source code alternatively since this is very specific to our device registration flow (and only used for the device data source) vs. a more generic retry mechanism at the moment.
neinkeinkaffee
force-pushed
the
gesa/device-datasource-waitfor
branch
from
57a6673 to
35977ce
Compare
mpminardi
reviewed
Apr 14, 2026
| } | ||
|
|
||
| if len(devices) == 0 { | ||
| return errors.New("could not find device with" + filterDesc) |
Member
There was a problem hiding this comment.
Nit: should add a space here to make this more readable:
Suggested change
| return errors.New("could not find device with" + filterDesc) | |
| return errors.New("could not find device with " + filterDesc) |
mpminardi
approved these changes
Apr 14, 2026
Member
mpminardi
left a comment
mpminardi
left a comment
There was a problem hiding this comment.
Apologies, my PR that adjusted one of the error messages in the device data source is now causing a conflict here (and the error source has been removed entirely now 🙈 ).
This adds the retry logic for the device datasource reads which had been missed in the initial migration. Updates tailscale.com/corp#37224 Signed-off-by: Gesa Stupperich <gesa@tailscale.com>
Updates tailscale.com/corp#37224 Signed-off-by: Gesa Stupperich <gesa@tailscale.com>
This is better to test against regressions during future refactorings than testing the retry logic itself which is an implementation detail. Updates tailscale.com/corp#37224 Signed-off-by: Gesa Stupperich <gesa@tailscale.com>
neinkeinkaffee
force-pushed
the
gesa/device-datasource-waitfor
branch
from
35977ce to
2d8760e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the retry logic for the device datasource reads which had been missed in the initial migration. It also moves to using filter parameters in the request instead of filtering the response.
Updates tailscale/corp#37224
Terraform acceptance test: https://github.com/tailscale/corp/actions/runs/24337213200/job/71057801192