Editorial: simplify a step in SetValueInBuffer#3819
Open
michaelficarra wants to merge 1 commit intomainfrom
Open
Editorial: simplify a step in SetValueInBuffer#3819michaelficarra wants to merge 1 commit intomainfrom
michaelficarra wants to merge 1 commit intomainfrom
Conversation
ljharb
reviewed
Apr 11, 2026
| 1. Let _execution_ be _AR_.[[CandidateExecution]]. | ||
| 1. Let _eventsRecord_ be the Agent Events Record of _execution_.[[EventsRecords]] whose [[AgentSignifier]] is AgentSignifier(). | ||
| 1. If _isTypedArray_ is *true* and IsNoTearConfiguration(_type_, _order_) is *true*, let _noTear_ be *true*; else let _noTear_ be *false*. | ||
| 1. If _isTypedArray_ is *true*, let _noTear_ be IsNoTearConfiguration(_type_, _order_); else let _noTear_ be *false*. |
Member
There was a problem hiding this comment.
how is this simplified? it's just moving where the "let" happens, and making only one of the possible values be hardcoded, which seems at best the same, and at worst more complex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.