editorial: add a value liveness note#135
Open
legendecas wants to merge 1 commit intomasterfrom
Open
Conversation
legendecas
force-pushed
the
liveness
branch
2 times, most recently
from
65586c9 to
349f5fb
Compare
|
|
||
| <emu-note> | ||
| <p>The value field [[AsyncContextValue]] in the list [[AsyncContextMapping]] of an Agent Record is only intended to be accessed via an [[AsyncContextKey]] field. The list is not iterable through AsyncContext APIs.</p> | ||
| <p>The above definition implies that, if a value in the [[AsyncContextKey]] field in an Async Context Mapping Record is not live, then its corresponding value of [[AsyncContextValue]] is not necessarily live either.</p> |
Member
There was a problem hiding this comment.
I think the semantics here could be better expressed in two steps:
- A live
[[AsyncContextMapping]]does not necessarily keep its[[AsyncContextKey]]s alive - For a live
[[AsyncContextMapping]], if an[[AsyncContextKey]]is not live, its corresponding[[AsyncContextValue]]is not necessarily kept alive.
nicolo-ribaudo
previously approved these changes
Mar 24, 2026
nicolo-ribaudo
dismissed
their stale review
Agree with Andreu's suggestion, but keeping it in a note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The [[AsyncContextMapping]] is never going to be a WeakMap equivalent storage, providing operations like
delete,get,has, orset. It is only intended to say that the value in anAsync Context Mapping Recordis only necessarily live when its corresponding key is live.Fixes: #76