Support client authority in config profiles#1004
Draft
kevinawoo wants to merge 1 commit intotemporalio:mainfrom
Draft
Support client authority in config profiles#1004kevinawoo wants to merge 1 commit intotemporalio:mainfrom
kevinawoo wants to merge 1 commit intotemporalio:mainfrom
Conversation
dc75e29 to
f2b8289
Compare
f2b8289 to
8b6186f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client_authorityprofile property, withclient-authorityaccepted as a flag-style alias.client_authority.--client-authorityis explicitly set.Root Cause
client-authorityexisted as a runtime client flag, buttemporal config setonly accepted properties backed by the SDK envconfig profile reflection map. Since envconfig has noClientAuthorityfield, the property was rejected and could not be persisted.Validation
go test -mod=readonly ./internal/temporalcli -run 'TestApplyClientAuthorityFromConfig|TestConfig' -count=1go test ./... -count=1currently fails before running tests in this checkout because the ignored localvendor/directory is incomplete (vendor/modules.txtis missing), so Go reports inconsistent vendoring. Use-mod=readonlyhere or regenerate vendor from a clean vendor directory.