Skip to content

Support client authority in config profiles#1004

Draft
kevinawoo wants to merge 1 commit intotemporalio:mainfrom
kevinawoo:config-profile-client-authority
Draft

Support client authority in config profiles#1004
kevinawoo wants to merge 1 commit intotemporalio:mainfrom
kevinawoo:config-profile-client-authority

Conversation

@kevinawoo
Copy link
Copy Markdown
Member

@kevinawoo kevinawoo commented Apr 28, 2026

Summary

  • Add a persisted client_authority profile property, with client-authority accepted as a flag-style alias.
  • Round-trip envconfig additional profile fields so config rewrites preserve unknown TOML keys, including client_authority.
  • Apply configured client authority to CLI client options unless --client-authority is explicitly set.

Root Cause

client-authority existed as a runtime client flag, but temporal config set only accepted properties backed by the SDK envconfig profile reflection map. Since envconfig has no ClientAuthority field, the property was rejected and could not be persisted.

Validation

  • go test -mod=readonly ./internal/temporalcli -run 'TestApplyClientAuthorityFromConfig|TestConfig' -count=1
  • go test ./... -count=1 currently fails before running tests in this checkout because the ignored local vendor/ directory is incomplete (vendor/modules.txt is missing), so Go reports inconsistent vendoring. Use -mod=readonly here or regenerate vendor from a clean vendor directory.

@kevinawoo kevinawoo force-pushed the config-profile-client-authority branch 2 times, most recently from dc75e29 to f2b8289 Compare April 29, 2026 00:22
@kevinawoo kevinawoo force-pushed the config-profile-client-authority branch from f2b8289 to 8b6186f Compare April 29, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant