-
Notifications
You must be signed in to change notification settings - Fork 178
Eager Workflow Start #1757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Eager Workflow Start #1757
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8d972ca
Add requestEagerStart
THardy98 956beef
adapt legacy start interceptors
THardy98 b22143a
use test env connection
THardy98 1ac9aca
addressing pr feedback:
THardy98 b40a55c
update comments, move inteceptor adapters to wf client creation
THardy98 c38d662
fix, linting, formatting
THardy98 33d672c
revert movement of interceptor adapters to wf client creation
THardy98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { WorkflowClientInterceptor, WorkflowStartInput, WorkflowStartOutput } from './interceptors'; | ||
|
|
||
| export function adaptWorkflowClientInterceptor(i: WorkflowClientInterceptor): WorkflowClientInterceptor { | ||
| return adaptLegacyStartInterceptor(i); | ||
| } | ||
|
|
||
| // Adapt legacy `start` interceptors to the new `startWithDetails` interceptor. | ||
| function adaptLegacyStartInterceptor(i: WorkflowClientInterceptor): WorkflowClientInterceptor { | ||
| // If it already has the new method, or doesn't have the legacy one, no adaptation is needed. | ||
| // eslint-disable-next-line deprecation/deprecation | ||
| if (i.startWithDetails || !i.start) { | ||
| return i; | ||
| } | ||
|
|
||
| // This interceptor has a legacy `start` but not `startWithDetails`. We'll adapt it. | ||
| return { | ||
| ...i, | ||
| startWithDetails: async (input, next): Promise<WorkflowStartOutput> => { | ||
| let downstreamOut: WorkflowStartOutput | undefined; | ||
|
|
||
| // Patched `next` for legacy `start` interceptors. | ||
| // Captures the full `WorkflowStartOutput` while returning `runId` as a string. | ||
| const patchedNext = async (patchedInput: WorkflowStartInput): Promise<string> => { | ||
| downstreamOut = await next(patchedInput); | ||
| return downstreamOut.runId; | ||
| }; | ||
|
|
||
| const runIdFromLegacyInterceptor = await i.start!(input, patchedNext); // eslint-disable-line deprecation/deprecation | ||
|
|
||
| // If the interceptor short-circuited (didn't call `next`), `downstreamOut` will be undefined. | ||
| // In that case, we can't have an eager start. | ||
| if (downstreamOut === undefined) { | ||
| return { runId: runIdFromLegacyInterceptor, eagerlyStarted: false }; | ||
| } | ||
|
|
||
| // If `next` was called, honor the `runId` from the legacy interceptor but preserve | ||
| // the `eagerlyStarted` status from the actual downstream call. | ||
| return { ...downstreamOut, runId: runIdFromLegacyInterceptor }; | ||
| }, | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.