gcs: add endpoint configuration option#257
Open
rohansood10 wants to merge 1 commit intothanos-io:mainfrom
Open
gcs: add endpoint configuration option#257rohansood10 wants to merge 1 commit intothanos-io:mainfrom
rohansood10 wants to merge 1 commit intothanos-io:mainfrom
Conversation
Add an Endpoint field to the GCS bucket configuration that allows specifying a custom GCS API endpoint. This is useful for testing with emulators or connecting to GCS-compatible storage services. The endpoint is passed through as a google.golang.org/api/option WithEndpoint option when creating the GCS client. Also updates README.md to document the new configuration field. Fixes: thanos-io/thanos#7862 Signed-off-by: Rohan Sood <56945243+rohansood10@users.noreply.github.com>
rohansood10
force-pushed
the
fix/7862-gcs-custom-endpoint
branch
from
b8d46c5 to
34b9f71
Compare
Author
|
@bwplotka @JoaoBraveCoding @GiedriusS hey! Fixed the DCO sign-off issue and rebased onto main. Would appreciate a review when you get a chance - this adds a configurable endpoint option for GCS, useful for emulator testing and GCS-compatible storage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Thanos currently does not support configuring a custom API endpoint for Google Cloud Storage. This prevents using GCS regional endpoints or GCS-compatible storage backends.
Fixes: thanos-io/thanos#7862
Solution
Added an
endpointfield to the GCSConfigstruct. When set, it is passed asoption.WithEndpoint()when creating the GCS storage client.Configuration example
Changes
Endpointfield toConfigstruct and wired it throughNewBucketWithConfigviaoption.WithEndpoint()Notes
endpointis empty (default), behavior is unchanged