Skip to content

ci: Use msrv aware dependency resolver#3633

Open
tottoto wants to merge 2 commits intotokio-rs:mainfrom
tottoto:msrv-aware-resolver
Open

ci: Use msrv aware dependency resolver#3633
tottoto wants to merge 2 commits intotokio-rs:mainfrom
tottoto:msrv-aware-resolver

Conversation

@tottoto
Copy link
Copy Markdown
Collaborator

@tottoto tottoto commented Jan 12, 2026

Uses the MSRV aware dependency resolver.

@mladedav
Copy link
Copy Markdown
Collaborator

I always though that we also tried to check that the minimum versions work (e.g. we're not using API from newer versions). Do we want to add another test for that or do we care just about MSRV? I'm honestly not sure if it's worth it so we can maybe merge as is.

@mladedav mladedav added the T-ci Topic: CI label Apr 10, 2026
@tottoto
Copy link
Copy Markdown
Collaborator Author

tottoto commented Apr 10, 2026

I think the minimal dependency version should be checked. I would think it would be worth maintaining, if it can be implemented more simply.

@mladedav
Copy link
Copy Markdown
Collaborator

mladedav commented Apr 10, 2026

To have both, we can either keep it as is or have two different jobs, one for msrv (what you did here) and one for minimum dependencies (either what this was before or the same with newer toolchain or even just nightly since we need nightly cargo anyway). So two jobs I guess?

@tottoto tottoto force-pushed the msrv-aware-resolver branch 3 times, most recently from e318215 to 297c30b Compare April 10, 2026 19:15
@tottoto
Copy link
Copy Markdown
Collaborator Author

tottoto commented Apr 10, 2026

So two jobs I guess?

Yes. I think so.

And, as an additional benefit of separating them, the effects can be removed, which are caused by dev-dependencies and private features. On the other hand, it looks more cumbersome since we need to specify all features instead of --all-features option.

@tottoto tottoto force-pushed the msrv-aware-resolver branch from 297c30b to 8dc9c17 Compare April 10, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-ci Topic: CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants