Skip to content

chore(eslint-plugin): switch auto-generated test cases to hand-written in no-unsafe-enum-comparison.test.ts#12261

Open
Vinccool96 wants to merge 1 commit intotypescript-eslint:mainfrom
Vinccool96:chore/12238-no-unsafe-enum-comparison-hand-written
Open

chore(eslint-plugin): switch auto-generated test cases to hand-written in no-unsafe-enum-comparison.test.ts#12261
Vinccool96 wants to merge 1 commit intotypescript-eslint:mainfrom
Vinccool96:chore/12238-no-unsafe-enum-comparison-hand-written

Conversation

@Vinccool96
Copy link
Copy Markdown
Contributor

PR Checklist

Overview

  • Change dynamic test cases using spread and map to handwritten ones
  • Zero (0) existing recurring cases have been removed
  • No further recurring cases exist

@typescript-eslint
Copy link
Copy Markdown
Contributor

Thanks for the PR, @Vinccool96!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 21, 2026

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f721006
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/69e799a65e84c7000821818c
😎 Deploy Preview https://deploy-preview-12261--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 21, 2026

View your CI Pipeline Execution ↗ for commit f721006

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 2m 17s View ↗
nx run generate-configs ✅ Succeeded 5s View ↗
nx run-many -t typecheck ✅ Succeeded 43s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded 2s View ↗
Additional runs (34) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2026-04-21 15:44:30 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.81%. Comparing base (6d599b4) to head (f721006).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12261      +/-   ##
==========================================
+ Coverage   86.71%   86.81%   +0.09%     
==========================================
  Files         513      513              
  Lines       16271    16476     +205     
  Branches     5060     5136      +76     
==========================================
+ Hits        14109    14303     +194     
- Misses       1474     1478       +4     
- Partials      688      695       +7     
Flag Coverage Δ
unittest 86.81% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repo: [no-unsafe-enum-comparison.test.ts] Switch auto-generated test cases to hand-written

1 participant