-
Notifications
You must be signed in to change notification settings - Fork 20
chore: update deps #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
chore: update deps #456
Changes from all commits
f25da10
0a4b987
eecee8a
3025e2c
46f4975
db9f397
447c83c
701b0db
4266fca
4ec1124
7aa5277
4af8161
f420be7
117ebd4
8e75dd5
d761b00
4115480
cf8290a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -161,13 +161,13 @@ import { WebEvent } from '@/helpers/WebEvent'; | |
| import { useAuthStore } from '@/stores/auth'; | ||
| import { applyChartsTheme } from '@/theme'; | ||
|
|
||
| const router = useRouter(); | ||
| const router = useRouter() as ReturnType<typeof useRouter> | undefined; | ||
|
||
| const authStore = useAuthStore(); | ||
| const theme = useTheme(); | ||
|
|
||
| const getCurrentDate = () => dayjs(); | ||
|
|
||
| const layout = computed(() => router.currentRoute.value.meta.layout ?? null); | ||
| const layout = computed(() => router?.currentRoute?.value?.meta?.layout ?? null); | ||
|
|
||
| const handleLogout = () => { | ||
| authStore.logOut(); | ||
|
|
@@ -178,7 +178,7 @@ const createAccount = () => { | |
| source: 'app_bar_sidebar', | ||
| }); | ||
|
|
||
| router.push('/signup'); | ||
| router?.push('/signup'); | ||
| }; | ||
|
|
||
| const drawer = ref(false); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major version upgrade from vue-router 4.6.4 to 5.0.2. Major version upgrades typically include breaking changes. The code changes in AppBar.vue (lines 164, 170, 181) suggest handling cases where router might be undefined, which indicates awareness of potential breaking changes. However, please ensure all vue-router usage throughout the codebase has been reviewed for compatibility with version 5.x breaking changes, particularly around router initialization and type definitions.