Fix lint errors and update molecule for ansible v2.8

[lhoss]

Changes proposed in this pull request:

• Fixes all yaml lint and ansible lint errors that appeared due to recent ansible-lint module updates
• also had to update to the latest molecule version, for compatibility with ansible v2.8.x (which got used automatically by using recent docker containers, at least in my kdc-with-replica tests, see upcoming PR)
• The explicit install of cerberus v1.3.1, indeed required (to fix some schema error), can be removed once we have a molecule release that contains the fix from Bump cerberus ansible/molecule#2103 (merged to master since the 17.06.2019)

Full credits go to @NadOby, who initially contributed these fixes to a PR in our repo (
scigility#1), which I had to rebase, because it was derived from an unfinished branch

[NadOby]

This one is pretty straightforward, the only fishy part is fixing versions of packages in .travis.yml
This should be revisited in a month or two, hopefully, molecule will update from master when.

[lhoss]

@HorizonNet , @matb Any interest in merging this? (and see also #22)

[HorizonNet]

@lhoss I've followed the discussions over the last few days, but didn't have the time yet to look into the changes. One of our colleagues is currently checking and testing the changes. I hope that I find some time over the weekend to look into them.

[murtazahassan123]

@lhoss
Just a small question; why are you using release candiadate and not release version in "pip install molecule==2.22rc1"?

[HorizonNet]

LGTM overall. Left a minor comment.

[HorizonNet]

I also like that you're going to improve the quality score of the module. Thanks!

[lhoss]

Just a small question; why are you using release candiadate and not release version in "pip install molecule==2.22rc1"?

@SyedMurtazaHassan I had to use that rc1 version because of the 2nd point I mentioned (in PR desc.):

• also had to update to the latest molecule version, for compatibility with ansible v2.8.x (which got used automatically by using recent docker containers, at least in my kdc-with-replica tests, see upcoming PR)

---

Please use a stable version of molecule instead of a release candidate.

@HorizonNet I just checked if there's a newer release out, but nope!

• Maybe there's even a 2.20.2 released before 2.22 (that fixes ansible 2.8.x compatibility): Upgrade testinfra ansible/molecule#2169

So if we want to merge this these days (not waiting for new molecule release), I do not see another option than:

• Downgrade molecule again to latest stable and thus fixing the ansible version in the build to a recent 2.7.x (and hoping the other done test improvements still work with older molecule /testinfra deps)
• or stay with the molecule 'rc' version (I just tested with the latest RC 2.22rc3, which worked well, plus this version fixed the cerberus+flake8 pip deps)

Pragmatically, to not loose time (getting it working) with the old molecule version (that seems also much slower during infratests taking 80s vs 10s on my Macbook), I'ld favor to accept the 'rc' version, since it's working nicely (and of course changing to the release as soon as it is released)
Wdyt ?

[lhoss]

Please use a stable version of molecule instead of a release candidate.

@HorizonNet I just checked if there's a newer release out, but nope!

Finally a new molecule stable version came out (2.22), the 18.8.2019!
I just updated the PR to that version, so it can be finally merged, @HorizonNet !
Will rebase this change also in the other open PR!

[HorizonNet]

LGTM. Let's wait for the build results.