fix(server): catch synchronous exceptions in middleware passes#109
Conversation
Forward synchronous errors thrown by middleware passes (e.g. ERR_INVALID_HTTP_TOKEN) to the error event instead of crashing the process. Ref: http-party/node-http-proxy#1680
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 96.14% 96.26% +0.11%
==========================================
Files 8 8
Lines 623 643 +20
Branches 233 241 +8
==========================================
+ Hits 599 619 +20
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
_createProxyFnwith try/catch to handle synchronous exceptions (e.g.,ERR_INVALID_HTTP_TOKENfrom invalid headers)errorevent; otherwise the promise rejectsRef: http-party/node-http-proxy#1680
Test plan
errorevent when listener existserrorlistener