feat: Add a GitHub Actions workflow for use in CI workflows#339
feat: Add a GitHub Actions workflow for use in CI workflows#339Lamparter wants to merge 3 commits into
Conversation
|
|
jeromelaban
left a comment
jeromelaban
left a comment
There was a problem hiding this comment.
Thanks for your contribution! A few adjustments are needed but this is a good addition!
| - name: Install ${{ inputs.target-platform }} Workloads | ||
| shell: pwsh | ||
| run: | | ||
| dotnet tool install -g uno.check | ||
| ("${{ inputs.target-platform }} ".Split(' ') | ForEach-Object { | ||
| $target = $_.Replace("_win", "").Replace("_macos", "") | ||
| if (![string]::IsNullOrEmpty($target)) { | ||
| echo "target: $target" | ||
| uno-check -v --ci --non-interactive --fix --target $target --skip vswin --skip vsmac --skip xcode --skip vswinworkloads --skip androidemulator --skip dotnetnewunotemplates | ||
| echo "uno-check finished for target: $target " | ||
| } | ||
| }) |
There was a problem hiding this comment.
We probably could avoid running uno-check in a loop by adding multiple --target options instead.
There was a problem hiding this comment.
What do you mean?
This is the standard behaviour of the mini-workflow step included in the Uno platform template.
There was a problem hiding this comment.
Ah! That's right, then the other one probably should be changed as well, but that will do for now then.
| - name: Install ${{ inputs.target-platform }} Workloads | ||
| shell: pwsh | ||
| run: | | ||
| dotnet tool install -g uno.check | ||
| ("${{ inputs.target-platform }} ".Split(' ') | ForEach-Object { | ||
| $target = $_.Replace("_win", "").Replace("_macos", "") | ||
| if (![string]::IsNullOrEmpty($target)) { | ||
| echo "target: $target" | ||
| uno-check -v --ci --non-interactive --fix --target $target --skip vswin --skip vsmac --skip xcode --skip vswinworkloads --skip androidemulator --skip dotnetnewunotemplates | ||
| echo "uno-check finished for target: $target " | ||
| } | ||
| }) |
There was a problem hiding this comment.
Ah! That's right, then the other one probably should be changed as well, but that will do for now then.
Co-authored-by: Jérôme Laban <jlaban@gmail.com>
|
Hello @Lamparter @jeromelaban , |
4 participants
This PR implements an alternative way for consuming Uno.Check - from GitHub Actions.
This will appear in the GitHub Marketplace once a release on the repo is published or a tag is created.
This also removes the need for the massive unnecessary workflow files shipped with the Uno templates wizard downstream.