feat: Transparent icon background on non-mobile#17855
Closed
MartinZikmund wants to merge 2 commits into
Closed
Conversation
MartinZikmund
changed the title
MartinZikmund
changed the title
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17855/index.html |
7 tasks
jeromelaban
approved these changes
Aug 26, 2024
morning4coffe-dev
approved these changes
Aug 26, 2024
Member
|
I need those changes, very nice! 🚀 |
Contributor
|
The build 135420 found UI Test snapshots differences: Details
|
Member
Author
|
unoplatform/uno.resizetizer#310 needs to be merged first |
morning4coffe-dev
added
the
do-not-merge/work-in-progress
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17855/index.html |
Contributor
|
The build 140297 found UI Test snapshots differences: Details
|
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days. |
github-actions
Bot
added
the
stale
MartinZikmund
removed
the
stale
Member
Author
|
Not stale, blocked by unoplatform/uno.resizetizer#310 |
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days. |
github-actions
Bot
added
the
stale
MartinZikmund
removed
the
stale
MartinZikmund
force-pushed
the
dev/mazi/icon-background
branch
from
c3187ab to
b3cc776
Compare
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17855/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17855/docs/index.html |
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days. |
github-actions
Bot
added
the
stale
MartinZikmund
removed
the
stale
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days. |
github-actions
Bot
added
the
stale
Member
github-actions
Bot
removed
the
stale
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days. |
github-actions
Bot
added
the
stale
Contributor
|
This PR was closed because it has been stalled for 10 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires unoplatform/uno.resizetizer#310
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Icon background file is used by default on WinUI, Desktop and WASM
What is the new behavior?
Not used by default
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):