fix: NPE when web push subscription is expired (CP: 24.10)#24311
Merged
Conversation
When the push service reports a subscription as expired, `WebPush.sendNotification` threw `NullPointerException` instead of the intended `WebPushException`. Remove a leftover reference to an unassigned `HttpResponse` local variable that was no longer populated after the migration to `com.interaso.webpush`. Fixes #24306
Contributor
|
For some reason the webpush module gets on this branch. |
Collaborator
Author
|
The issue is that the root POM configures a JUnit 4 test listener for the surefire plugin, but the class is in the generic test modules that flow-webpush does not depend on. |
caalador
reviewed
May 11, 2026
| <version>2.2.21</version> | ||
| </dependency> | ||
|
|
||
| <!-- |
Contributor
There was a problem hiding this comment.
The non dependency could be cleaned from the pom as it seems the empty listener property is enough
mcollovati
commented
May 11, 2026
caalador
approved these changes
May 11, 2026
|
mshabarov
pushed a commit
that referenced
this pull request
May 11, 2026
…CP: 24.9) (#24319) This PR cherry-picks changes from the original PR #24311 to branch 24.9. --- #### Original PR description > When the push service reports a subscription as expired, `WebPush.sendNotification` threw `NullPointerException` instead of the intended `WebPushException`. > > Remove a leftover reference to an unassigned `HttpResponse` local variable that was no longer populated after the migration to `com.interaso.webpush`. > > Fixes #24306 > Co-authored-by: Marco Collovati <marco@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the push service reports a subscription as expired,
WebPush.sendNotificationthrewNullPointerExceptioninstead of the intendedWebPushException.Remove a leftover reference to an unassigned
HttpResponselocal variable that was no longer populated after the migration tocom.interaso.webpush.Fixes #24306