Skip to content

fix: NPE when web push subscription is expired (#24310) (CP: 25.0)#24317

Merged
vaadin-bot merged 2 commits into
25.0from
cherry-pick-24310-to-25.0-1778483804250
May 11, 2026
Merged

fix: NPE when web push subscription is expired (#24310) (CP: 25.0)#24317
vaadin-bot merged 2 commits into
25.0from
cherry-pick-24310-to-25.0-1778483804250

Conversation

@vaadin-bot
Copy link
Copy Markdown
Collaborator

@vaadin-bot vaadin-bot commented May 11, 2026

This PR cherry-picks changes from the original PR #24310 to branch 25.0.

Original PR description

When the push service reports a subscription as expired, WebPush.sendNotification threw NullPointerException instead of the intended WebPushException.

Remove a leftover reference to an unassigned HttpResponse local variable that was no longer populated after the migration to com.interaso.webpush.

Fixes #24306

@mcollovati @vaadin-bot
fix: NPE when web push subscription is expired (#24310)
612cf1b 
When the push service reports a subscription as expired,
`WebPush.sendNotification` threw `NullPointerException` instead of the
intended `WebPushException`.

Remove a leftover reference to an unassigned `HttpResponse` local
variable that was no longer populated after the migration to
`com.interaso.webpush`.

Fixes #24306
@vaadin-bot
Copy link
Copy Markdown
Collaborator Author

vaadin-bot commented May 11, 2026

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) May 11, 2026 07:24
@vaadin-bot
Copy link
Copy Markdown
Collaborator Author

vaadin-bot commented May 11, 2026

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026 •
edited
Loading

Test Results

1 320 files  +1  1 320 suites  +1   1h 21m 49s ⏱️ - 1m 31s
9 421 tests +2  9 354 ✅ +2  67 💤 ±0  0 ❌ ±0 
9 881 runs  +8  9 806 ✅ +8  75 💤 ±0  0 ❌ ±0 

Results for commit e94a7ee. ± Comparison against base commit 4492d01.

♻️ This comment has been updated with latest results.

@vaadin-bot
Copy link
Copy Markdown
Collaborator Author

vaadin-bot commented May 11, 2026

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot]

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 11, 2026

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vaadin-bot
Copy link
Copy Markdown
Collaborator Author

vaadin-bot commented May 11, 2026

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit bd5befa into 25.0 May 11, 2026
29 of 30 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-24310-to-25.0-1778483804250 branch May 11, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees

No one assigned

Labels

+0.0.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaadin-bot @vaadin-review-bot @mcollovati