#77599 š bug: fix infinite loop caused by redirect function with emptā¦#92750
Open
sergioramirez-dev wants to merge 10 commits intovercel:canaryfrom
Open
#77599 š bug: fix infinite loop caused by redirect function with emptā¦#92750sergioramirez-dev wants to merge 10 commits intovercel:canaryfrom
sergioramirez-dev wants to merge 10 commits intovercel:canaryfrom
Conversation
ā¦h empty string value.
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Author
sergioramirez-dev
left a comment
There was a problem hiding this comment.
Have added URL guard to permanentRedirect and added just one test condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Prevent infinite redirect loop for redirect("")
Problem
Calling redirect("") results in an infinite redirect loop in the browser due to an empty Location header, which resolves to the current URL.
Cause
The redirect response sets Location: "", and the client router does not guard against self-redirects.
Solution
Validate the redirect target and reject empty strings.
Changes
Tests
Throws on redirect("") and redirect(" ")
Valid redirects unchanged.
Notes
This prevents undefined behavior and improves error clarity. Treating empty strings as invalid is preferred over silent normalization.
Closes #77599