Skip to content

Revamped caching system#199

Open
vermiculus wants to merge 13 commits intomasterfrom
caching
Open

Revamped caching system#199
vermiculus wants to merge 13 commits intomasterfrom
caching

Conversation

@vermiculus
Copy link
Copy Markdown
Owner

Not ready for merge yet. Use this PR as a discussion medium.

Addresses #88.

@Malabarba
Copy link
Copy Markdown
Collaborator

I have a general question here regarding what your plans are. Specifically, about the elements of sx-cache--cache-volatility-alist.

Is CACHE a symbol? If so, can't it be the same symbol as VARIABLE?
What did you have in mind for these two?

This commit will break Travis for this branch.  stash.el has yet to be
released.  It will be released to MELPA and then to ELPA pending
paperwork (at which point it will be removed from MELPA).
This obsoletes sx-cache.
Ensure application data is written before Emacs is killed.
Comment thread sx.el
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think this ought to be handled by stash.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it's a programmer's interface, I was hesitant to introduce functionality that wasn't specifically requested. Having gone through to use it, though, you're right – there are very few cases in which it isn't desired. A no-load flag to defstash would suffice.

Hopefully this will also resolve those issues Travis has been having
downloading the right version...
Comment thread sx-auth.el
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given how catastrophic it would be to have two stashes with the same file name, maybe we should use more specific names for future stashes. Or (even better) maybe stash.el could take care of choosing unique file names based on variable name.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter option seems good, but what else would auth be used for (in our case specifically)?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I don't know. I don't think we should change this variable specifically. It just occurred to me we might want to use longer names on future stashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants