Skip to content

Fix cache's file permission to 600#318

Open
Yuki-Inoue wants to merge 1 commit intovermiculus:masterfrom
Yuki-Inoue:fix-file-permission
Open

Fix cache's file permission to 600#318
Yuki-Inoue wants to merge 1 commit intovermiculus:masterfrom
Yuki-Inoue:fix-file-permission

Conversation

@Yuki-Inoue
Copy link
Copy Markdown

Since cache includes private information, (the auth-info), it's
permission should be set to 600.

Since cache includes private information, (the auth-info), it's
permission should be set to 600.
@vermiculus
Copy link
Copy Markdown
Owner

Change looks good, thanks :) but it seems our tests need updating…

@Malabarba @jrblevin Has anything changed with markdown processing that could cause indented space after a code block?

i.e.,

screen shot 2016-05-15 at 9 52 17 am

@Malabarba
Copy link
Copy Markdown
Collaborator

We could probably just change our renderer to delete-trailing-whitespace after everything is done rendering.

@jrblevin
Copy link
Copy Markdown

I see that the text in the screenshot is from a test case. Should I think of it as pre-existing text that is fontified using markdown-mode, or is it being inserted and/or filled using markdown-mode functions? In other words, how does one reproduce this in a markdown-mode buffer?

@vermiculus
Copy link
Copy Markdown
Owner

I'm going to revamp the tests separately; we'll see how things fall after that.

@vermiculus
Copy link
Copy Markdown
Owner

I never did get around to revamping tests. Is this something that's still valuable to merge after all this time? Happy to do so if so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants