Skip to content

fix(wasix): Return error when close_fd encountered an error#6451

Merged
Arshia001 merged 2 commits intomainfrom
fix/fs-close-error
Apr 20, 2026
Merged

fix(wasix): Return error when close_fd encountered an error#6451
Arshia001 merged 2 commits intomainfrom
fix/fs-close-error

Conversation

@artemyarulin
Copy link
Copy Markdown
Contributor

Fixes #6436

@artemyarulin
Copy link
Copy Markdown
Contributor Author

/patchsmith test

@artemyarulin
Copy link
Copy Markdown
Contributor Author

Python upstream result: IMPROVEMENT

Baseline: main @ df125df
Candidate: fix/fs-close-error @ 4329350

Summary:

  • Regressions: 0
  • Improvements: 3
  • FLAKY: 4 -> 13
  • PASS: 28324 -> 28327
  • FAIL: 2607 -> 2600
  • TIMEOUT: 4871 -> 4875
  • SKIP: 2105 -> 2105

See full details at commit.

Top improvements:

  • test.test_fileio.CAutoFileTests.testErrnoOnClose (FAIL -> PASS)
  • test.test_fileio.PyAutoFileTests.testErrnoOnClose (FAIL -> PASS)
  • test.test_json.test_recursion.TestCRecursion.test_endless_recursion (FAIL -> PASS)

More info:

@Arshia001 Arshia001 merged commit 05fc61f into main Apr 20, 2026
77 checks passed
@Arshia001 Arshia001 deleted the fix/fs-close-error branch April 20, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

close() succeeds on already-closed file descriptors under Wasmer

2 participants