Add a flag allowing interop view to be viewed everywhere#3001
Add a flag allowing interop view to be viewed everywhere#3001gsnedders wants to merge 1 commit intoweb-platform-tests:mainfrom
Conversation
|
The deployment failed because this PR is from a fork. I am happy to deploy one manually after the review |
|
@jgraham Do you have opinions on this? |
|
Yes, I continue to believe this is a bad idea. The Interop-202x tests are special in that we've got mutual agreement that they make sense to score in this way. We don't have that agreement for arbitary tests, so I don't think we should add an override like this. |
IMO, flags are sufficiently niche that this risk is very low, for the same reason as why having colours on the homepage behind a flag isn't harmful. |
|
Also, like, to be explicit, the current logic is very naïve and easy to work around: searching for And as justification: being able to actually see how browsers do (under the current scoring) on things proposed for Interop 2023 is valuable during the review time period. |
Description
This adds a flag which overrides the default logic for allowing the interop scores.
Review Information
As I understand it, we pull defaults from somewhere server-side; it's not clear to me where actually controls this. As I understand, it sounds like
people with admin accounts on wpt.fyi can change these defaults, but given they default to false this shouldn't need anything to be done there.
Note I haven't actually tested this (I don't have a working local setup), so someone who does should probably test this as part of the review.