Blink WPT: stabilize text-combine-upright reftests#59139
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Apr 13, 2026
Merged
Blink WPT: stabilize text-combine-upright reftests#59139chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
Wait for Ahem before taking reftest snapshots in css-ruby and css-writing-modes text-combine-upright tests. This avoids fallback-font first layout differences and makes snapshots deterministic. Remove temporary Linux Failure Pass expectations now that these tests are stable again. Bug: 495770240,431038526 Change-Id: I29b4d8f38c9c2e58e54b4e8e2377cc0663daff50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7705114 Reviewed-by: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> Auto-Submit: Helmut Januschka <helmut@januschka.com> Commit-Queue: Helmut Januschka <helmut@januschka.com> Cr-Commit-Position: refs/heads/main@{#1613609}
baab983 to
d3d2419
Compare
wpt-pr-bot
approved these changes
Apr 13, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for Ahem before taking reftest snapshots in css-ruby and
css-writing-modes text-combine-upright tests. This avoids fallback-font
first layout differences and makes snapshots deterministic.
Remove temporary Linux Failure Pass expectations now that these tests
are stable again.
Bug: 495770240,431038526
Change-Id: I29b4d8f38c9c2e58e54b4e8e2377cc0663daff50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7705114
Reviewed-by: Yoav Weiss (@Shopify) <yoavweiss@chromium.org>
Auto-Submit: Helmut Januschka <helmut@januschka.com>
Commit-Queue: Helmut Januschka <helmut@januschka.com>
Cr-Commit-Position: refs/heads/main@{#1613609}